Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So, this adds no features, but it does ensure thread safety of the code base. It fixes #25
There are two areas this affects:
Player.Queue
, which was modified and read in different goroutines. This code adds control via anRWMutex
. I considered, and rejected, accessors; there few enough similar uses to seem worth it.It's probably rare for any users to hit any of these. I put this in while trying to debug a different issue, which it didn't solve... but this change makes the code safer, so...